improve jump colors for github_dark themes #10946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-mikedavis
previously approved these changes
Jun 13, 2024
merisbahti
force-pushed
the
jump-colors-github-dark
branch
from
a2c5cfb
to
09124e3
Compare
|
Sorry, can you review again? The color in the theme was actually wrong |
the-mikedavis
approved these changes
Jun 14, 2024
pascalkuthe
approved these changes
Jun 18, 2024
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
mxxntype
pushed a commit
to mxxntype/helix
that referenced
this pull request
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The colors while using the newly introduced jump feature have been bugging me, especially in the github_dark family of themes.
Before
(I can hardly see this, especially the jump characters on selection)
After